Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase and changes to PR 1647 #1813

Merged
merged 2 commits into from Jan 4, 2019
Merged

Rebase and changes to PR 1647 #1813

merged 2 commits into from Jan 4, 2019

Conversation

shaan1337
Copy link
Member

@shaan1337 shaan1337 commented Jan 4, 2019 •
edited

Thanks to @hanxinimm for this nice feature!

This is a rebase of #1647 with some changes:

  • The format is now: ${env:<Referenced_Env_Var>} instead of [<Referenced_Env_Var>]
  • Tests added

The PR basically allows you to reference another environment variable. It may be useful to reference existing IP address environment variables set in containers (like Service Fabric's Fabric_NodeIPOrFQDN)

Test example:
Linux

export HELLO=All
export EVENTSTORE_RUN_PROJECTIONS=\${env:HELLO}

Windows

set HELLO=All
set EVENTSTORE_RUN_PROJECTIONS=${env:HELLO}

Then run an EventStore node and it should apply the RunProjections=All configuration.

hanxinimm and others added 2 commits January 4, 2019 14:09
@hanxinimm @shaan1337
* Add Fabric Service EnvironmentVariable Config On Deploy an existing…
6284379 
… executable to Service Fabric

<EnvironmentVariable Name="EVENTSTORE_EXT_IP" Value="[Fabric_NodeIPOrFQDN]"/>
[VariableName] Reference System EnvironmentVariable Or Service Fabric environment variables
PS:
https://docs.microsoft.com/en-us/azure/service-fabric/service-fabric-environment-variables-reference
@shaan1337 @hanxinimm
Update the regular expression to match ${env:<ENV VARIABLE>}
91be946 
Add tests
Parse referenced environment variables in EventStore.Rags.EnvironmentVariables.Parse itself

Co-Authored-By: 韩鑫 <hanxinimm@163.com>
@shaan1337 shaan1337 added the area/documentation Issues relating to project documentation label Jan 4, 2019
@shaan1337 shaan1337 mentioned this pull request Jan 4, 2019
Closed
@shaan1337 shaan1337 merged commit da800ad into master Jan 4, 2019
@shaan1337 shaan1337 deleted the rags-environment-ref branch January 4, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/documentation Issues relating to project documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaan1337 @hanxinimm